1. Лучший говнокод

    В номинации:
    За время:

  2. PHP / Говнокод #17716

    +159

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    41. 41
    42. 42
    43. 43
    44. 44
    45. 45
    46. 46
    47. 47
    48. 48
    49. 49
    50. 50
    51. 51
    52. 52
    53. 53
    54. 54
    55. 55
    56. 56
    57. 57
    58. 58
    59. 59
    60. 60
    61. 61
    62. 62
    63. 63
    64. 64
    65. 65
    66. 66
    67. 67
    if (!isset($_GET['outbox']) and !isset($_GET['deleted']) and !isset($_GET['verification'])){
				$res2 = mysql_query("SELECT l.* FROM letters l LEFT JOIN `customers` ct ON ct.id=l.from_user WHERE l.deleted<>1 AND ct.`Sex` = 'male' {$addon_sql} ORDER BY l.time_insert DESC");
				for($arr=array(); $t = mysql_fetch_assoc($res2); $arr[]=$t);

				smarty_put_var('zagolovok', 'Входящие письма');
		}

		if (isset($_GET['verification'])) {
		$res2 = mysql_query("SELECT * FROM `letters` where `deleted` != 1 AND `checked` = 'N' {$addon_sql} order by `time_insert` DESC");
		for($arr = array(); $t = mysql_fetch_assoc($res2); $arr[] = $t);

		smarty_put_var('zagolovok', 'Ожидающие проверку');
		}

		if (isset($_GET['outbox'])) {
    	$res2 = mysql_query("SELECT l.* FROM `letters` l
		    	LEFT JOIN `customers` ct ON ct.`id`=l.from_user
		    	WHERE l.deleted != 1 AND ct.`Sex` = 'female' {$addon_sql}
		    	ORDER BY l.time_insert DESC LIMIT 200");
		    	for ($arr = array(); $t = mysql_fetch_assoc($res2); $arr[]=$t);

		    	smarty_put_var('zagolovok', 'Исходящие письма');
		}

		    	if (isset($_GET['deleted'])){
    	$res2 = mysql_query("SELECT * FROM `letters` WHERE `deleted` = 1
		    	{$addon_sql} ORDER BY `time_insert` DESC");
		    	for($arr=array(); $t=mysql_fetch_assoc($res2); $arr[]=$t);

		    	smarty_put_var('deleted', true);
		    	smarty_put_var('zagolovok', 'Удаленные письма');
		    	}

		    	$letters = array_slice($arr, $first, $limit);

		foreach ($letters as &$letter) {
			$letter['from_user_details'] = Model_Table_Customers::model()
				->fetchByPk($letter['from_user']);
			$letter['to_user_details'] = Model_Table_Customers::model()
				->fetchByPk($letter['to_user']);
		}

if (isset($_GET['outbox'])){smarty_put_var('pages', pages_admin("?module=admin_letters&outbox&page=", $arr, $page, $limit)); smarty_put_var('type', 'outbox');}
elseif (isset($_GET['verification'])){smarty_put_var('pages', pages_admin("?module=admin_letters&verification&page=", $arr, $page, $limit)); smarty_put_var('type', 'verification');}
elseif (isset($_GET['deleted'])){smarty_put_var('pages', pages_admin("?module=admin_letters&deleted&page=", $arr, $page, $limit)); smarty_put_var('type', 'deleted');}
else {smarty_put_var('pages', pages_admin("?module=admin_letters&page=", $arr, $page, $limit)); smarty_put_var('type', '');}

...

function pages_admin($link, $arr, $page, $vis)
{
    $radius=4;
    $pages=floor(count($arr)/$vis);
    $return="";
    $str='<table cellpadding="0" cellspacing=3 border="0">
    <tr><td height=7></td></tr>
    <tr>';

    if ($pages > 1) {
        $first = 'First';
        $prev = 'Prev';
        $next = 'Next';
        $last = 'Last';

        if($page<$radius*2){
           .....
      трэшак в том же духе

    Очередной шедевр с сохранением авторского стиля и табуляции. Это подготовка для smarty представления таблицы с постраничной разбивкой. Возможны 4 типа писем - 4 вкладки. pages_admin() - возвращает пагинатор в виде готового html кода.

    Клиент жаловался, что страница сильно тормозит. Там более 150 000 писем. Я догадывался, что код можно чутка оптимизирвоать, но не думал, что существенно. А когда посмотрел вижу - п-ц ))) Интересно насколько получить ускорить?

    stechkh, 01 Марта 2015

    Комментарии (2)

  3. PHP / Говнокод #17692

    +158

    1. 1
    2. 2
    3. 3
    4. 4
    5. 5
    6. 6
    7. 7
    8. 8
    9. 9
    <?php if( !Yii::app()->user->checkAccess('Manager')){ ?><td class="text-center"><?php  if($project->c1Projects->stat_id==23){
                echo '|';
                }elseif($project->c1Projects->stat_id==496){
                    echo '||';
                }else{
                   echo  '-';
                }

    ?></td><?php } ?>

    Вюха одного проекта

    Elenberg, 24 Февраля 2015

    Комментарии (2)

  4. C# / Говнокод #17687

    +133

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    public string GenerateWinCode(String PrefixWinCode, String Name, String LastName, String NameCompany, bool IsCompany = false)
        {
            string _NormalWinCode = "";
            if (!IsCompany)
                _NormalWinCode = (PrefixWinCode + Name[0] + LastName[0]).ToUpper();
            else
            {
                var i = 1;
                try
                {
                    while (String.IsNullOrWhiteSpace(NameCompany[i].ToString()))
                    {
                        i++;
                    }
                    _NormalWinCode = (PrefixWinCode + NameCompany[0] + NameCompany[i]).ToUpper();
                }
                catch (Exception)
                {
                    _NormalWinCode = (PrefixWinCode + NameCompany[0] + NameCompany[0]).ToUpper();
                }
            }
            if (PrefixWinCode == "IN")
                throw new RuleException("ErrorWincode", Resources.Accounts.Account.WincodeInvalid);
            try
            {
                using (var context = db)
                {
                    var _WincodesSim =
                        (from q in context.UserPartners.Where(m => m.WinCode.ToUpper().StartsWith(_NormalWinCode))
                         where q.WinCode.Length > 4
                         select q.WinCode).ToList();
                    var _Sufix = _WincodesSim.Select(m => Convert.ToInt32(m.Substring(4))).Max();
                    return _NormalWinCode + (_Sufix + 1);
                }
            }
            catch (InvalidOperationException)
            {
                return _NormalWinCode + 1;
            }
        }

    Генерация уникальных ключей

    AndrewTakker, 24 Февраля 2015

    Комментарии (2)

  5. C# / Говнокод #17684

    +137

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    public bool StartListener()
		{
			bool flag;
			try
			{
				flag = (this.m_Listener.BeginAccept() ? true : false);
			}
			catch (Exception exception)
			{
				CAssert.ReportAssert(exception);
				flag = false;
			}
			return flag;
		}

    Из реального корпоративного проекта.

    Danmer, 23 Февраля 2015

    Комментарии (2)

  6. Python / Говнокод #17675

    −115

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    41. 41
    42. 42
    43. 43
    44. 44
    45. 45
    46. 46
    47. 47
    48. 48
    49. 49
    50. 50
    51. 51
    def checkio(res):
    #bruteforce LOL
    if res[0][0] == res[1][0] == res[2][0] == "X":
        return "X"

    if res[0][1] == res[1][1] == res[2][1] == "X":
        return "X"

    if res[0][2] == res[1][2] == res[2][2] == "X":
        return "X"

    if res[0][0] == res[0][1] == res[0][2] == "X":
        return "X"

    if res[1][0] == res[1][1] == res[1][2] == "X":
        return "X"  

    if res[2][0] == res[2][1] == res[2][2] == "X":
        return "X"

    if res[0][0] == res[1][1] == res[2][2] == "X":
        return "X" 

    if res[0][2] == res[1][1] == res[2][0] == "X":
        return "X"

    if res[0][0] == res[1][0] == res[2][0] == "O":
        return "O"    

    if res[0][1] == res[1][1] == res[2][1] == "O":
        return "O"

    if res[0][2] == res[1][2] == res[2][2] == "O":
        return "O"

    if res[0][0] == res[0][1] == res[0][2] == "O":
        return "O"

    if res[1][0] == res[1][1] == res[1][2] == "O":
        return "O"
        
    if res[2][0] == res[2][1] == res[2][2] == "O":
        return "O"

    if res[0][0] == res[1][1] == res[2][2] == "O":
        return "O"        

    if res[0][2] == res[1][1] == res[2][0] == "O":
        return "O"

    return "D"

    Определить результат игры в крестики нолики.

    gost, 22 Февраля 2015

    Комментарии (2)

  7. PHP / Говнокод #17665

    +161

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    public function set_debug($fparam) {
     $this->set_debug_mode($fparam);
}

protected function set_debug_mode($fparam) {
      $this->set_localization_debug_mode($fparam);
}

private function set_localization_debug_mode($fparam) {
      $this->set_localization_debug_mode_log_service($fparam);
}

private function set_localization_debug_mode_log_service($fparam) {
      $conf = //...тут уже что-то делает, наконец-то
}

    Я понимаю, если бы они просто были алиасами... Но почему protected/private?

    Lowezar, 18 Февраля 2015

    Комментарии (2)

  8. Java / Говнокод #17649

    +74

    1. 1
    2. 2
    3. 3
    4. 4
    /**
 * singletone staff:
 */
private static LogisticsAppContext local;

    Однотонный посох?

    someone, 16 Февраля 2015

    Комментарии (2)

  9. PHP / Говнокод #17613

    +157

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    13. 13
    14. 14
    15. 15
    16. 16
    17. 17
    18. 18
    19. 19
    20. 20
    21. 21
    22. 22
    23. 23
    24. 24
    25. 25
    26. 26
    27. 27
    28. 28
    29. 29
    30. 30
    31. 31
    32. 32
    33. 33
    34. 34
    35. 35
    36. 36
    37. 37
    38. 38
    39. 39
    40. 40
    /**
	 * @return DevblocksSearchField[]
	 */
	static function getFields() {
		$translate = DevblocksPlatform::getTranslationService();
		
		$columns = array(
			SearchFields_Ticket::TICKET_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_ID, 't', 'id', $translate->_('common.id'), Model_CustomField::TYPE_NUMBER),
			SearchFields_Ticket::TICKET_MASK => new DevblocksSearchField(SearchFields_Ticket::TICKET_MASK, 't', 'mask', $translate->_('ticket.mask'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_SUBJECT => new DevblocksSearchField(SearchFields_Ticket::TICKET_SUBJECT, 't', 'subject', $translate->_('ticket.subject'), Model_CustomField::TYPE_SINGLE_LINE),
			
			SearchFields_Ticket::TICKET_FIRST_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_MESSAGE_ID, 't', 'first_message_id'),
			SearchFields_Ticket::TICKET_FIRST_OUTGOING_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_OUTGOING_MESSAGE_ID, 't', 'first_outgoing_message_id'),
			SearchFields_Ticket::TICKET_LAST_MESSAGE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_MESSAGE_ID, 't', 'last_message_id'),
			
			SearchFields_Ticket::TICKET_FIRST_WROTE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_ID, 't', 'first_wrote_address_id'),
			SearchFields_Ticket::TICKET_FIRST_WROTE => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE, 'a1', 'email',$translate->_('ticket.first_wrote'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_FIRST_WROTE_FIRST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_FIRST_NAME, 'a1', 'first_name', $translate->_('ticket.first_wrote') . ' First Name'),
			SearchFields_Ticket::TICKET_FIRST_WROTE_LAST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_LAST_NAME, 'a1', 'last_name', $translate->_('ticket.first_wrote') . ' Last Name'),
			SearchFields_Ticket::TICKET_FIRST_WROTE_SPAM => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_SPAM, 'a1', 'num_spam',$translate->_('address.num_spam'), Model_CustomField::TYPE_NUMBER),
			SearchFields_Ticket::TICKET_FIRST_WROTE_NONSPAM => new DevblocksSearchField(SearchFields_Ticket::TICKET_FIRST_WROTE_NONSPAM, 'a1', 'num_nonspam',$translate->_('address.num_nonspam'), Model_CustomField::TYPE_NUMBER),
				
			SearchFields_Ticket::TICKET_LAST_WROTE_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_ID, 't', 'last_wrote_address_id'),
			SearchFields_Ticket::TICKET_LAST_WROTE => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE, 'a2', 'email',$translate->_('ticket.last_wrote'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::TICKET_LAST_WROTE_FIRST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_FIRST_NAME, 'a2', 'first_name', $translate->_('ticket.last_wrote') . ' First Name'),
			SearchFields_Ticket::TICKET_LAST_WROTE_LAST_NAME => new DevblocksSearchField(SearchFields_Ticket::TICKET_LAST_WROTE_LAST_NAME, 'a2', 'last_name', $translate->_('ticket.last_wrote') . ' Last Name'),
				
			SearchFields_Ticket::ORG_NAME => new DevblocksSearchField(SearchFields_Ticket::ORG_NAME, 'o', 'name', $translate->_('contact_org.name'), Model_CustomField::TYPE_SINGLE_LINE),
			SearchFields_Ticket::REQUESTER_ADDRESS => new DevblocksSearchField(SearchFields_Ticket::REQUESTER_ADDRESS, 'ra', 'email',$translate->_('ticket.requester'), Model_CustomField::TYPE_SINGLE_LINE),
			
			SearchFields_Ticket::TICKET_ORG_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_ORG_ID, 't','org_id',$translate->_('contact_org.id')),
			SearchFields_Ticket::TICKET_OWNER_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_OWNER_ID,'t','owner_id',$translate->_('common.owner'), Model_CustomField::TYPE_WORKER),
			SearchFields_Ticket::TICKET_GROUP_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_GROUP_ID,'t','group_id',$translate->_('common.group')),
			SearchFields_Ticket::TICKET_BUCKET_ID => new DevblocksSearchField(SearchFields_Ticket::TICKET_BUCKET_ID, 't', 'bucket_id',$translate->_('common.bucket')),
			SearchFields_Ticket::TICKET_CREATED_DATE => new DevblocksSearchField(SearchFields_Ticket::TICKET_CREATED_DATE, 't', 'created_date',$translate->_('common.created'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_UPDATED_DATE => new DevblocksSearchField(SearchFields_Ticket::TICKET_UPDATED_DATE, 't', 'updated_date',$translate->_('common.updated'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_CLOSED_AT => new DevblocksSearchField(SearchFields_Ticket::TICKET_CLOSED_AT, 't', 'closed_at',$translate->_('ticket.closed_at'), Model_CustomField::TYPE_DATE),
			SearchFields_Ticket::TICKET_WAITING => new DevblocksSearchField(SearchFields_Ticket::TICKET_WAITING, 't', 'is_waiting',$translate->_('status.waiting'), Model_CustomField::TYPE_CHECKBOX),
			SearchFields_Ticket::TICKET_CLOSED => new DevblocksSearchField(SearchFields_Ticket::TICKET_CLOSED, 't', 'is_closed',$translate->_('status.closed'), Model_CustomField::TYPE_CHECKBOX),
			SearchFields_Ticket::TICKET_DELETED => new DevblocksSearchField(SearchFields_Ticket::TICKET_DELETED, 't', 'is_deleted',$translate->_('status.deleted'), Model_CustomField::TYPE_CHECKBOX),

    https://github.com/jstanden/cerb6/blob/6.9.1/features/cerberusweb.core/api/dao/ticket.php#L1979

    lav45, 10 Февраля 2015

    Комментарии (2)

  10. Java / Говнокод #17589

    +78

    1. 01
    2. 02
    3. 03
    4. 04
    5. 05
    6. 06
    7. 07
    8. 08
    9. 09
    10. 10
    11. 11
    12. 12
    for (int i = 0; i < 100 && components.isEmpty(); i++) {
            try {
                Thread.sleep(1000); 
            } catch (InterruptedException ie) {
                    /* shouldn't happen */
            }
            components = parent.getChildrenByObjType(type);
            LOG.debug("Iteration " + i +"components = " + components);
        }
        if (components.isEmpty()) {
            throw new RuntimeException(COMPONENT_NOT_FOUND);
        }

    зуб, что через 100 итераций со слипом в 1 секунду, коллекция components точно будет заполнена!

    edhex, 06 Февраля 2015

    Комментарии (2)

  11. Куча / Говнокод #17571

    +132

    1. 1
    .gen-tabs .acctab:hover, .gen-tabs .acctab:focus, .gen-tabs .acctab.current { Carat up! }

    Говняшечка

    elvis, 04 Февраля 2015

    Комментарии (2)