- 1
<td width:6px="">
Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!
+124.6
<td width:6px="">
Без комментариев...
+170.3
// http://userscripts.org/scripts/review/23705
var replyBoxContentPostAreaTableSubjectRowRightColumnSubmitButton = document.createElement("input");
replyBoxContentPostAreaTableSubjectRowRightColumnSubmitButton.setAttribute("type", "submit");
replyBoxContentPostAreaTableSubjectRowRightColumnSubmitButton.setAttribute("value", "Submit");
replyBoxContentPostAreaTableSubjectRowRightColumn.appendChild(replyBoxContentPostAreaTableSubjectRowRightColumnSubmitButton);
replyBoxContentPostAreaTableSubjectRow.appendChild(replyBoxContentPostAreaTableSubjectRowLeftColumn);
replyBoxContentPostAreaTableSubjectRow.appendChild(replyBoxContentPostAreaTableSubjectRowRightColumn);
replyBoxContentPostAreaTBody.appendChild(replyBoxContentPostAreaTableSubjectRow);
Грустно. Очень грустно.
+109.4
//Dictionary used to check if eventValues are unique
Dictionary<string, string> uniqueEventValues = new Dictionary<string, string>();
//... заполняем коллекцию
try {
uniqueEventValues.Add(eventValue, "X");
}
catch (Exception ex) {
if (ex.Message.Equals("An item with the same key has already been added.")) {
msgAddEventParams.Text = "EventValues must be unique. " + eventValue + " is duplicate.";
msgAddEventParams.Visible = true;
return;
}
}
мы не ищем легких путей!
+162.9
// Реализованно не верно, надо узнать как разобраться.
$.prototype.deleteClass = function(name) // Удаляет один из классов элемента
{ // Пример:$('closeSpan').deleteClass('dialogTitleCloseSpanOver');
this.setClass( (this.className()).replace(" "+name+" ", ' ') );
this.setClass( (this.className()).replace(""+name+" ", ' ') );
this.setClass( (this.className()).replace(" "+name+"", ' ') );
return this;
}
Я плакалЪ.
+158.2
if(!$result = MYSQL_QUERY("SELECT gmr_id, gam_chip, gam_price, gam_status FROM ".PREFIX."_games;")) { die(mysql_error()); exit; }
if(MYSQL_NUMROWS($result))
{
while($rows = mysql_fetch_row($result))
{
if(isset($gmr_chip[$rows[0]])) $gmr_chip[$rows[0]] += $rows[1];
else $gmr_chip[$rows[0]] = $rows[1];
if(isset($gmr_price[$rows[0]])) $gmr_price[$rows[0]] += $rows[2];
else $gmr_price[$rows[0]] = $rows[2];
}
}
if(!$result = MYSQL_QUERY("SELECT gmr_id, gmr_regdate, gmr_login, gmr_mail, gmr_credits, gmr_money, gmr_status, gmr_birthday, adv_id FROM ".PREFIX."_gamers WHERE gmr_birthday != '';")) { die(mysql_error()); exit; }
if(MYSQL_NUMROWS($result))
{
while($rows = mysql_fetch_row($result))
{
$gmr_id[$rows[0]] = $rows[0];
$gmr_regdate[$rows[0]] = $rows[1];
$gmr_login[$rows[0]] = $rows[2];
$gmr_mail[$rows[0]] = $rows[3];
$gmr_credits[$rows[0]] = $rows[4];
$gmr_money[$rows[0]] = $rows[5];
$gmr_status[$rows[0]] = $rows[6];
$gmr_birthday[$rows[0]] = $rows[7];
if(!isset($gmr_quations[$rows[0]])) $gmr_quations[$rows[0]] = 0;
if(!isset($gmr_chip[$rows[0]])) $gmr_chip[$rows[0]] = 0;
if(!isset($gmr_price[$rows[0]])) $gmr_price[$rows[0]] = 0;
if(isset($gmr_adverted[$rows[8]])) $gmr_adverted[$rows[8]]++;
else $gmr_adverted[$rows[8]] = 1;
$gadv_id[$rows[0]] = $rows[8];
}
}
MYSQL_QUERY("DROP TABLE ".PREFIX."_tmp_gamers;");
if (!mysql_query ("CREATE TABLE ".PREFIX."_tmp_gamers (
gmr_id INT UNSIGNED NOT NULL AUTO_INCREMENT,
gmr_regdate DATE NOT NULL,
gmr_login CHAR(32) NOT NULL,
gmr_mail CHAR(32) NOT NULL,
gmr_credits INT UNSIGNED NOT NULL,
gmr_money DEC(10, 2) UNSIGNED NOT NULL,
gmr_status INT UNSIGNED NOT NULL,
gmr_birthday CHAR(12) NOT NULL,
gmr_quations INT UNSIGNED NOT NULL,
gmr_chip DEC(10, 2) UNSIGNED NOT NULL,
gmr_price DEC(10, 2) UNSIGNED NOT NULL,
gmr_adverted INT UNSIGNED NOT NULL,
adv_id INT UNSIGNED NOT NULL,
UNIQUE KEY (gmr_id));")) { die(mysql_error()); exit; }
$first = true;
$query = "INSERT INTO ".PREFIX."_tmp_gamers VALUES ";
if(isset($gmr_id))
{
foreach($gmr_id as $key)
{
if(!$first) $query .= ', ';
else $first = false;
if(!isset($gmr_adverted[$key])) $gmr_adverted[$key] = 0;
$query .= "($gmr_id[$key], '$gmr_regdate[$key]', '$gmr_login[$key]', '$gmr_mail[$key]', $gmr_credits[$key], $gmr_money[$key], $gmr_status[$key], '$gmr_birthday[$key]', $gmr_quations[$key], $gmr_chip[$key], $gmr_price[$key], $gmr_adverted[$key], $gadv_id[$key])";
}
$query .= ";";
if(!MYSQL_QUERY($query)) { die(mysql_error()); exit; }
}
unset($gmr_id);
unset($gmr_regdate);
unset($gmr_login);
unset($gmr_mail);
unset($gmr_credits);
unset($gmr_money);
unset($gmr_status);
unset($gmr_birthday);
unset($gmr_quations);
unset($gmr_chip);
unset($gmr_price);
unset($gmr_adverted);
unset($gadv_id);
$type = 'norm';
И кучка unset-ов! Ты гляди - он еще и память экономит!
В таблице _gamers over 5k записей. Не трудно догадаться, каких размеров получается строка $query? И главный вопрос: нахрена временная таблица?
+142.6
using System;
using Nemerle.Collections;
using Nemerle.Text;
using Nemerle.Utility;
using System.Runtime.InteropServices;
namespace nCdy
{
/// <summary>
/// Description of Win32API.
/// </summary>
public static class Win32API
{
[ Flags ]
public enum AllocationType
{
| Commit = 0x1000
}
[ Flags ]
public enum ProcessAccess : int
{
| VMOperation = 0x8
| VMRead = 0x10
| VMWrite = 0x20
}
[ Flags ]
public enum MemoryProtection
{
| ReadWrite = 0x04
}
//[StructLayout(LayoutKind.Sequential)]
public struct LUID {
internal LowPart : uint;
internal HighPart : uint;
}
//[StructLayout(LayoutKind.Sequential)]
public struct TOKEN_PRIVILEGES
{
public PrivilegeCount : UInt32;
public Luid : LUID;
public Attributes : UInt32;
}
public struct MOUSEINPUT
{
dx : int;
dy : int;
mouseData : int;
dwFlags : int;
time : int;
dwExtraInfo : IntPtr;
}
public struct KEYBDINPUT
{
public mutable wVk : char ;
public wScan : short ;
public dwFlags : int ;
public time : int ;
public dwExtraInfo : IntPtr ;
}
public struct HARDWAREINPUT
{
uMsg : int ;
wParamL : short ;
wParamH : short ;
}
[StructLayout(LayoutKind.Explicit)]
public struct INPUT
{
[FieldOffset(0)]
public mutable typefield : int ;
[FieldOffset(4)]
mi : MOUSEINPUT;
[FieldOffset(4)]
public mutable ki : KEYBDINPUT;
[FieldOffset(4)]
hi : HARDWAREINPUT;
}
[DllImport("user32.dll")]
public static extern keybd_event(
bVk : byte,
bScan : byte,
dwFlags : uint,
dwExtraInfo : UIntPtr) : void ;
[DllImport("user32.dll")]
ООП
+156
$('.value_field').bind('change', function() {
$('.' + $(this).attr('id')).val($(this).val());
});
+160.2
<?
function freadbyte($f)
{
return ord(fread($f,1));
};
function freadword($f)
{
$b1=freadbyte($f);
$b2=freadbyte($f);
return $b2*256+$b1;
};
function freadlngint($f)
{
return freaddword($f);
};
function freaddword($f)
{
$b1=freadword($f);
$b2=freadword($f);
return $b2*65536+$b1;
};
?>
полный набор из побочных эффектов, магических цифр, лишних переменных и алиасов
−852.1
CREATE TABLE account(
balance INT DEFAULT 0,
name VARCHAR(60) NOT NULL,
surname VARCHAR(60) DEFAULT NULL,
login VARCHAR(60) NOT NULL,
password VARCHAR(256) NOT NULL,
active BOOLEAN DEFAULT FALSE,
UNIQUE KEY login (login),
id INT AUTO_INCREMENT PRIMARY KEY
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8
CREATE TABLE email(
email VARCHAR(255) NOT NULL,
user_id INT NOT NULL,
UNIQUE KEY email (email),
id INT AUTO_INCREMENT PRIMARY KEY,
FOREIGN KEY (user_id) REFERENCES account (id)
ON DELETE CASCADE
ON UPDATE CASCADE
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8
CREATE TABLE prefered_email(
email_id VARCHAR(255) NOT NULL,
user_id INT NOT NULL,
id INT AUTO_INCREMENT PRIMARY KEY,
FOREIGN KEY (user_id) REFERENCES account (id)
ON DELETE CASCADE
ON UPDATE CASCADE,
FOREIGN KEY (email_id) REFERENCES email (id)
ON DELETE CASCADE
ON UPDATE CASCADE
) ENGINE = InnoDB DEFAULT CHARACTER SET utf8
При попытке создать prefered_email получаю ошибку: Error: Can't create table './nightfol_print/prefered_phone.frm' (errno: 150)
В чем может быть беда?
Максимум что нашел, это что http://www.sql.ru/forum/actualthread.aspx?tid=626099 типы id должны быть одинаковы ... но они и есть. И все таблицы InnoDB.
Подскажите, пожалуйста.
+162.1
<?
/* Для spaw нужно */
$spaw_root = dirname(__FILE__) . "/spaw/";
include $spaw_root . 'spaw_control.class.php';
/* Проверка на существование раздела */
if (count($glb_page->prop))
{
load_lib("pw_mod");
$glb_page->main_out = run_action($glb_page->prop['id_act'],1);
// подключение шаблона
if (isset($_GET['pw_patt'])) $glb_page->prop['templ'] = $_GET['pw_patt'];
if (isset($_POST['pw_patt'])) $glb_page->prop['templ'] = $_POST['pw_patt'];
if (isset($_REQUEST['pw_patt'])) $glb_page->prop['templ'] = $_REQUEST['pw_patt'];
include(pw_Path_templ . $glb_page->prop['templ'] . ".php");
}
else
{
echo "Раздел не найден";
}
?>