Говнокод: по колено в коде.

• Все
• Лучший
• Сток
• Глупый поиск
• Наговнокодить!
• Oтзывы

Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!

1. PHP (5706)
2. C++ (2739)
3. Куча (2360)
4. JavaScript (2030)
5. C# (1928)
6. Java (1502)
7. Си (1115)
8. Pascal (647)
9. Python (583)
10. 1C (538)
11. SQL (432)
12. ActionScript (292)
13. Objective C (202)
14. bash (198)
15. Perl (194)
16. Assembler (146)
17. Ruby (145)
18. VisualBasic (138)
19. Lua (49)
20. Go (31)
21. Swift (27)
22. Haskell (26)
23. Kotlin (14)

1. PHP / Говнокод #80

   +40.6

   1. 1
   2. 2

   Application was halted by an exception.
   Debug-mode is off.

   Ошибка на govnokod.ru при добавлении комментариев

   guest, 08 Декабря 2008

   Комментарии (12)

2. PHP / Говнокод #69

   +30.6

   1. 001
   2. 002
   3. 003
   4. 004
   5. 005
   6. 006
   7. 007
   8. 008
   9. 009
   10. 010
   11. 011
   12. 012
   13. 013
   14. 014
   15. 015
   16. 016
   17. 017
   18. 018
   19. 019
   20. 020
   21. 021
   22. 022
   23. 023
   24. 024
   25. 025
   26. 026
   27. 027
   28. 028
   29. 029
   30. 030
   31. 031
   32. 032
   33. 033
   34. 034
   35. 035
   36. 036
   37. 037
   38. 038
   39. 039
   40. 040
   41. 041
   42. 042
   43. 043
   44. 044
   45. 045
   46. 046
   47. 047
   48. 048
   49. 049
   50. 050
   51. 051
   52. 052
   53. 053
   54. 054
   55. 055
   56. 056
   57. 057
   58. 058
   59. 059
   60. 060
   61. 061
   62. 062
   63. 063
   64. 064
   65. 065
   66. 066
   67. 067
   68. 068
   69. 069
   70. 070
   71. 071
   72. 072
   73. 073
   74. 074
   75. 075
   76. 076
   77. 077
   78. 078
   79. 079
   80. 080
   81. 081
   82. 082
   83. 083
   84. 084
   85. 085
   86. 086
   87. 087
   88. 088
   89. 089
   90. 090
   91. 091
   92. 092
   93. 093
   94. 094
   95. 095
   96. 096
   97. 097
   98. 098
   99. 099
   100. 100

   $cResult = mysql_query($cQuery) or die(mysql_error());
   if (mysql_num_rows($cResult) <= 0)
   {
   	if ( $_GET['extra'] == "a" || $_GET['extra'] == 4 || $_GET['extra'] == 16 || $_GET['extra'] == "n" || $_GET['extra'] == "m" || $_GET['extra'] == "m_in_cat" )
   		{}
   	else
   		{
   		echo CAT_NO_WALP;
   		}
   } else
   {
   	$Row = mysql_fetch_object($cResult);
   	$id = $Row->id;
   
   	if ( $_GET['extra'] == "a" )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == 4 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `four_three` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `four_three` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `four_three` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == 16 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `sixteen_ten` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `sixteen_ten` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `sixteen_ten` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "n" )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `status_NEW` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `status_NEW` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `status_NEW` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "m" )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "m_in_cat" )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC");
   		}
   	else
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");   ///-------------
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `approved` = '0' AND `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC");
   		}
   
   	if ( $_GET['extra'] == "a" && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == 4 && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `four_three` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `four_three` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `four_three` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == 16 && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `sixteen_ten` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `sixteen_ten` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `sixteen_ten` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "n" && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `status_NEW` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `status_NEW` = '1' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `status_NEW` = '1' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "m" && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' ORDER BY `ID` DESC");
   		}
   	elseif ( $_GET['extra'] == "m_in_cat" && $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `poster` = '".$_SESSION['userid']."' AND Category = '".$result_needed['id']."' ORDER BY `ID` DESC");
   		}
   	elseif ( $_SESSION['usergroupid'] > 3	elseif ( $_SESSION['usergroupid'] > 3 )
   		{
   		$result = mysql_query("SELECT * FROM `Wallpapers` WHERE `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");   ///-------------
   		$myresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC LIMIT ".$page*$picsperpage.",$picsperpage");
   		$countresult = mysql_query("SELECT * FROM `Wallpapers` WHERE `Category` = '".$id."' OR `Category` IN (SELECT `id` FROM `Categories` WHERE `Parent` = '".$id."') ORDER BY `ID` DESC");
   // И еще примерно столько же подобного говнеца. Сюда просто не влазит...
   	}

   Пустые ифы, куча лишних запросов.
   Очень яркий пример ИНДУСтриального программирования.

   guest, 08 Декабря 2008

   Комментарии (10)

3. PHP / Говнокод #68

   +22.9

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29
   30. 30
   31. 31
   32. 32
   33. 33
   34. 34
   35. 35
   36. 36
   37. 37

   $result = mysql_query("SELECT * FROM `Wallpapers` WHERE `Title` = '".$Title."'");
   $row = mysql_fetch_assoc($result);
   $wID=$row['ID'];
   $Wallpaper1=$row['Wallpaper1'];
   $Wallpaper2=$row['Wallpaper2'];
   $Wallpaper3=$row['Wallpaper3'];
   $Wallpaper4=$row['Wallpaper4'];
   $Wallpaper5=$row['Wallpaper5'];
   
   if ( $_SESSION['userid'] )
   	{ 
   	if ($Wallpaper1 != NULL) {
   		$size='';
   		$size=getimagesize("images/wallpapers/".$Wallpaper1);
   		$dHTML .= '<a class="preview" href="'.$image_path.'show/'.$Title.'/?w=1" style="text-decoration: underline;" onClick="alerts('.$wID.'); countIp();">'.$size[0].'x'.$size[1].'</a> ';
   	}
   	if ($Wallpaper2 != NULL) {
   		$size='';
   		$size=getimagesize("images/wallpapers/".$Wallpaper2);
   		$dHTML .= '<a class="preview" href="'.$image_path.'show/'.$Title.'/?w=2" style="text-decoration: underline;" onClick="alerts('.$wID.'); countIp();">'.$size[0].'x'.$size[1].'</a> ';
   	}
   	if ($Wallpaper3 != NULL) {
   		$size='';
   		$size=getimagesize("images/wallpapers/".$Wallpaper3);
   		$dHTML .= '<a class="preview" href="'.$image_path.'show/'.$Title.'/?w=3" style="text-decoration: underline;" onClick="alerts('.$wID.'); countIp();">'.$size[0].'x'.$size[1].'</a> ';
   	}
   	if ($Wallpaper4 != NULL) {
   		$size='';
   		$size=getimagesize("images/wallpapers/".$Wallpaper4);
   		$dHTML .= '<a class="preview" href="'.$image_path.'show/'.$Title.'/?w=4" style="text-decoration: underline;" onClick="alerts('.$wID.'); countIp();">'.$size[0].'x'.$size[1].'</a> ';
   	}
   	if ($Wallpaper5 != NULL) {
   		$size='';
   		$size=getimagesize("images/wallpapers/".$Wallpaper5);
   		$dHTML .= '<a class="preview" href="'.$image_path.'show/'.$Title.'/?w=5" style="text-decoration: underline;" onClick="alerts('.$wID.'); countIp();">'.$size[0].'x'.$size[1].'</a> ';
   	}
   	}

   guest, 08 Декабря 2008

   Комментарии (4)

4. PHP / Говнокод #67

   +50.8

   1. 1
   2. 2
   3. 3
   4. 4
   5. 5
   6. 6
   7. 7

   $find = str_replace(",", "", $find);
   $find = str_replace(".", "", $find);
   $find = str_replace("/", "", $find);
   $find = str_replace(" ", "", $find);
   $find = str_replace("-", "", $find);
   $find = str_replace("+", "", $find);
   $find = str_replace("#", "", $find);

   Регулярные выражения =)

   guest, 08 Декабря 2008

   Комментарии (24)

5. PHP / Говнокод #66

   +46

   1. 01
   2. 02
   3. 03
   4. 04
   5. 05
   6. 06
   7. 07
   8. 08
   9. 09
   10. 10
   11. 11
   12. 12
   13. 13
   14. 14
   15. 15
   16. 16
   17. 17
   18. 18
   19. 19
   20. 20
   21. 21
   22. 22
   23. 23
   24. 24
   25. 25
   26. 26
   27. 27
   28. 28
   29. 29

   function PagerStarter( $object_id, $object_url, $dbt, $maxwidth, $edittime, $level_step, $comments_per_page )
   {
   	if ( $_GET['from'] ) { $from = $_GET['from']; }
   	if ( $_POST['from'] ) { $from = $_POST['from']; }
   	if ( $_GET['current_page'] ) { $current_page = $_GET['current_page']; }
   	if ( $_POST['current_page'] ) { $current_page = $_POST['current_page']; }
   	if ( ( empty( $current_page ) == TRUE ) && ( empty( $from ) == TRUE ) )
   		{
   		$r = mysql_query( "SELECT * FROM ".$dbt." WHERE parent = '1' AND parent_image = '$object_id'".$e."" );
   		$r_count = mysql_num_rows ( $r );
   		$total_pages = 0;
   		$i = 0;
   		while ( $i < $r_count )
   			{
   			$total_pages = $total_pages + 1;
   			$i = $i + $comments_per_page;
   			}
   		if ( $total_pages == 0 )
   			{
   			$total_pages = 1;
   			}
   		for ( $i = 1 ; $i <= $total_pages ; $i++ )
   			{
   			$from_q = ( $i * $comments_per_page ) - $comments_per_page + 0;
   			}
   		$_GET['current_page'] = $total_pages;
   		$_GET['from'] = $from_q;
   		}
   }

   Особого внимания заслуживает деление сложением. Хотя тут еще достаточно говна :)

   guest, 07 Декабря 2008

   Комментарии (12)

6. PHP / Говнокод #63

   +32.7

   1. 1
   2. 2
   3. 3
   4. 4
   5. 5

   $id = 0;
   while (!$id || mysql_error()) {
       $id = rand(1, 10000000);
       mysql_query("INSERT INTO `table` (id) VALUES ('".$id."'");
   }

   guest, 06 Декабря 2008

   Комментарии (12)

7. PHP / Говнокод #53

   +24.7

   1. 1

   str_replace("\t", "     ", $file_new);

   4страйко)

   guest, 04 Декабря 2008

   Комментарии (16)

8. PHP / Говнокод #42

   +29

   1. 1
   2. 2
   3. 3
   4. 4

   $i = 1;
   while($i = 1){
   echo $i;
   }

   guest, 30 Ноября 2008

   Комментарии (18)

9. PHP / Говнокод #39

   +24.1

   1. 1

   echo 'когда сделают камменты?';

   guest, 30 Ноября 2008

   Комментарии (65)

10. PHP / Говнокод #38

    +24.7

    1. 1
    2. 2
    3. 3
    4. 4
    5. 5
    6. 6
    7. 7

    session_start();
    if ($_SESSION['ok'] !== 1){
    echo "Сделали , блок сесиией";
    $_SESSION['ok'] = '1';
     } else {
    echo "Блок!";
    }

    Mr_Smile: сматрите ) в первый раз на странице должна быть надпись "Сделали блок сессией"
    Mr_Smile: при последующих обновлениях надпись должн абыть "Блок"
    Mr_Smile: а сколько ни обновляй все кажет "Сделали блок сессией"
    Mr_Smile: я ахутнГ?
    
    http://www.govnokod.com/171

    guest, 29 Ноября 2008

    Комментарии (47)

• ← влево
• вправо →

• 571
• …
• 7
• 6
• 5
• 4
• 3
• 2
• 1