- 1
if (strlen($PARAM)<=0) $PARAM = " class=\"inputselect\" ";
Нашли или выдавили из себя код, который нельзя назвать нормальным, на который без улыбки не взглянешь? Не торопитесь его удалять или рефакторить, — запостите его на говнокод.ру, посмеёмся вместе!
+159
if (strlen($PARAM)<=0) $PARAM = " class=\"inputselect\" ";
Если длинна строки меньше нуля? Битрикс, ты серьёзно?
+156
function GetDataArray($qs)
{
$res = array();
$q = mysql_query($qs);
if ($q) {
while ($row = mysql_fetch_array($q)) {
array_push($res,$row);
}
}
return $res;
}
Других путей получить массив записей наверно для автора нет
+158
<?php if( !Yii::app()->user->checkAccess('Manager')){ ?><td class="text-center"><?php if($project->c1Projects->stat_id==23){
echo '|';
}elseif($project->c1Projects->stat_id==496){
echo '||';
}else{
echo '-';
}
?></td><?php } ?>
Вюха одного проекта
+162
taras@host ~/host/sites/default $ drush phpsh-console
php> var_dump(eval('array()'));
bool(false)
PHP Parse error: syntax error, unexpected end of file in /usr/local/lib/python2.7/dist-packages/phpsh/phpsh.php(591) : eval()'d code(1) : eval()'d code on line 1
О мой мозг...! А Python здесь причем?
+161
there is a reason why opencart is the no.1 most used ecommerce solution in places like china and india, its the easiest code base to understand!
--
many apps servers! what does that mean? you mean different applications running from the same framework?
you build each application starting from the index.php file and include what ever library classes you require.
--
"I agree with you that it's harder to write simple code, because REPEATING CODE IS HARD TO DEBUG HARD TO READ AND TO CORRECT. so it makes you waste a lot of time."
this is what search and replace is for!
Создатель опенкарта (Daniel Kerr) исходит на говно, много мякотки
http://www.techchattr.com/never-use-opencart#comment-1151857248
+160
foreach (scandir(DIR.'app'.SLASH.'lib') as $filename) {
$path = DIR.'app'.SLASH.'lib'.SLASH.$filename;
if (is_file($path) && substr($filename,strlen($filename)-4,4)=='.php') {
require_once($path);
}
}
foreach (scandir(DIR.'app'.SLASH.'models') as $filename) {
$path = DIR.'app'.SLASH.'models'.SLASH.$filename;
if (is_file($path) && substr($filename,strlen($filename)-4,4)=='.php') {
require_once($path);
}
}
foreach (scandir(DIR.'app'.SLASH.'ext') as $filename) {
$path = DIR.'app'.SLASH.'ext'.SLASH.$filename;
if (is_file($path) && substr($filename,strlen($filename)-4,4)=='.php') {
require_once($path);
}
}
Начался разбор проблемы со слов заказчика - "сайт долго грузится"
+157
function getMinQueueOrdering()
{
$sql="SELECT MAX(ordering)
FROM priceloaddata_queue";
.........
}
нет слов.
+168
define("OUTPUT_DIR_CSV", "kokoko/kukarek/files" . DIRECTORY_SEPARATOR);
+161
public function set_debug($fparam) {
$this->set_debug_mode($fparam);
}
protected function set_debug_mode($fparam) {
$this->set_localization_debug_mode($fparam);
}
private function set_localization_debug_mode($fparam) {
$this->set_localization_debug_mode_log_service($fparam);
}
private function set_localization_debug_mode_log_service($fparam) {
$conf = //...тут уже что-то делает, наконец-то
}
Я понимаю, если бы они просто были алиасами... Но почему protected/private?
+160
if ($sub_sub_sub_sub_category_id !== null) {
if ($this->core->countUrl > 5) {
header('Location: /404/');
}
foreach ($categories[$category_id][$sub_category_id][$sub_sub_category_id][$sub_sub_sub_category_id][$sub_sub_sub_sub_category_id] as $k1 => $v1) {
if ($k1 !== 0) {
foreach ($v1 as $k2 => $v2) {
if ($k2 !== 0) {
if ($this->core->translit($v2[0]) == $sub_sub_sub_category) {
$sub_sub_sub_sub_sub_category_id = $k1;
$sub_sub_sub_sub_sub_sub_category_id = $k2;
break;
}
}
}
}
}
$this->core->title($categories[$category_id][$sub_category_id][$sub_sub_category_id][$sub_sub_sub_category_id][$sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_sub_category_id][0]);
$bread_crumbs[] = array(
'text' => $categories[$category_id][$sub_category_id][$sub_sub_category_id][$sub_sub_sub_category_id][$sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_sub_category_id][0],
'url' => $location['alias'] . '/' . $this->core->translit($categories[$category_id][0]) . '/' . $this->core->translit($categories[$category_id][$sub_category_id][$sub_sub_category_id][0]) . '/' . $this->core->translit($categories[$category_id][$sub_category_id][$sub_sub_category_id][$sub_sub_sub_category_id][$sub_sub_sub_sub_category_id][0]) . '/' . $this->core->translit($categories[$category_id][$sub_category_id][$sub_sub_category_id][$sub_sub_sub_category_id][$sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_category_id][$sub_sub_sub_sub_sub_sub_category_id][0])
);
$query_add = "
AND (`market_item`.`category_key` = '" . $category_id . "')
AND `market_item`.`param` REGEXP '(\"" . $sub_sub_sub_sub_category_id . "\")'
";
$vip_query_add = "
AND `market_item`.`category_key` = '" . $category_id . "'
";
}